Improve reliability of some tests #1852
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR proposes the following changes to the tests:
CALLED_BACK
flags in several places to ensure callbacks are actually executed.unwrap
on the result of theset_ssl_context
call to ensure the call was successful.connector_no_hostname_can_disable_verify
toconnector_can_disable_verify
, and furthermore:verify_hostname
(unnecessary since verification of the server's certificate is disabled);foobar
tofizzbuzz
to emphasize that it is not checked.