Add issuer_name and reason_code to X509RevokedRef #1847
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Skepfyr
commented
Mar 17, 2023
sfackler
reviewed
Mar 17, 2023
sfackler
reviewed
Mar 17, 2023
sfackler
reviewed
Mar 17, 2023
Skepfyr
force-pushed
the
x509-revoked-extra-methods
branch
from
8b36151 to
30aa408
Compare
sfackler
reviewed
Mar 28, 2023
|
Nice - looks good! Can you add a few quick tests just confirming that the extension impls added work as expected? |
Skepfyr
force-pushed
the
x509-revoked-extra-methods
branch
from
d8e655a to
95680c8
Compare
|
@sfackler Would it be possible to get a new release with this fix in? It'll mean we can finally move off our internal fork. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.