Add JSON output capabilities #21

Twey · 2017-10-17T16:01:34Z

I needed this to be able to output JSON for parsing elsewhere.

sfackler · 2017-10-18T03:31:49Z

src/main.rs

@@ -50,6 +53,7 @@ Options:
    --charset CHARSET       Set the character set to use in output. Valid
                            values: utf8, ascii [default: utf8]
    -f, --format FORMAT     Format string for printing dependencies
+    -j, --json              Print a JSON representation of the tree


I think it'd make sense to match the --output-format flag that Cargo uses, and make the JSON representation compatible with that.

sfackler · 2017-10-18T03:32:21Z

src/main.rs

@@ -317,6 +330,13 @@ struct Graph<'a> {
    nodes: HashMap<&'a PackageId, NodeIndex>,
 }

+#[derive(Debug, Serialize, Deserialize)]


No need to implement Deserialize I don't think.

sfackler · 2017-10-18T03:33:26Z

src/main.rs

@@ -214,6 +219,14 @@ fn real_main(flags: Flags, config: &Config) -> CliResult {
                       flags.flag_all);
            println!("");
        }
+    } else if flags.flag_json {
+        println!("{}", serde_json::to_string_pretty(
+            &graph_to_tree(package.package_id(),


It seems a bit strange that this mode would ignore a bunch of the flags the other modes respect.

sfackler · 2017-10-18T03:33:53Z

Have you taken a look at cargo metadata? That's the main interface for interacting programmatically with Cargo.

Twey · 2017-10-20T16:02:36Z

Unfortunately cargo metadata doesn't output any information on resolved features, which I need, and also doesn't output a tree, which is handy for my use-case. While I could munge it into the right format, it seemed like a better option to reuse cargo-tree, since that's basically what it does already. I don't mind keeping this local if you don't want machine-friendly formats in cargo-tree, though.

sfackler · 2017-10-24T19:29:42Z

What do you mean by resolved features?

I would kind of like to keep this project focused on user-facing output.

add JSON output capabilities

5793f38

sfackler reviewed Oct 18, 2017

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add JSON output capabilities #21

Add JSON output capabilities #21

Twey commented Oct 17, 2017

sfackler Oct 18, 2017

sfackler Oct 18, 2017

sfackler Oct 18, 2017

sfackler commented Oct 18, 2017

Twey commented Oct 20, 2017 •

edited

Loading

sfackler commented Oct 24, 2017

Add JSON output capabilities #21

Are you sure you want to change the base?

Add JSON output capabilities #21

Conversation

Twey commented Oct 17, 2017

sfackler Oct 18, 2017

Choose a reason for hiding this comment

sfackler Oct 18, 2017

Choose a reason for hiding this comment

sfackler Oct 18, 2017

Choose a reason for hiding this comment

sfackler commented Oct 18, 2017

Twey commented Oct 20, 2017 • edited Loading

sfackler commented Oct 24, 2017

Twey commented Oct 20, 2017 •

edited

Loading