Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: 🤖 Devtools cleanup, generalized build process #189

Merged
merged 9 commits into from
May 3, 2022

Conversation

jsimck
Copy link
Contributor

@jsimck jsimck commented Apr 8, 2022

devtools was add to workspaces and cleaned up. Additional changes:

  • Removed multiple invaluable tests (in form of rendering the same snapshots without any value)
  • Merged webpack configurations for devtools and error-overlay to have the same process
  • Hoisted multiple devDependencies related to common webpack config to root package.json for better maintenance
  • migrated from webpack-cli to webpack-nano as it is much smaller package and we use it only tu run webpack config from command line (nothing else)
  • eslint-plugin-import is now applied to devtools package too
  • Moved devtools-scripts "string version" build from inline npm script to rollup config for better maintenance.
  • Added .module suffix to *.less files, since CSS modules are now optional (with proper suffix) and not enabled by default in the common config

@mjancarik mjancarik merged commit 35f4f87 into next May 3, 2022
@mjancarik mjancarik deleted the rebase-webpack-cleanup branch January 4, 2023 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants