Backported undefined url param error from next

seznam · Mar 6, 2023 · e0708dd · e0708dd
1 parent b4e7bad
commit e0708dd
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 1 deletion.
diff --git a/.changeset/ten-frogs-smoke.md b/.changeset/ten-frogs-smoke.md
@@ -0,0 +1,5 @@
+---
+"@ima/core": patch
+---
+
+Backport fix from `next` - for missing optional parameters in static router that are evaluated as 'undefined' instead of undefined.
diff --git a/packages/core/src/router/StaticRoute.ts b/packages/core/src/router/StaticRoute.ts
@@ -508,7 +508,7 @@ export default class StaticRoute extends AbstractRoute {
 
       if (currentCoreName) {
         const value = AbstractRoute.decodeURIParameter(rawValue) as string;
-        parameters[currentCoreName] = value;
+        parameters[currentCoreName] = rawValue ? value : rawValue;
       }
     }
 

diff --git a/packages/core/src/router/__tests__/StaticRouteSpec.ts b/packages/core/src/router/__tests__/StaticRouteSpec.ts
@@ -806,6 +806,11 @@ describe('ima.core.router.StaticRoute', function () {
         path: '/something/param1/user1',
         params: {},
       },
+      {
+        pathExpression: '/test/:?param1/:?param2',
+        path: '/test/xxx',
+        params: { param1: 'xxx', param2: undefined },
+      },
     ].forEach(value => {
       it(value.pathExpression, function () {
         const localStaticRoute = new StaticRoute(