Merge pull request #166 from seznam/node-20-support

fix: integration tests support for Node 19+
seznam · May 10, 2024 · 1e9b0ba · 1e9b0ba
2 parents 0ef276e + 97b056b
commit 1e9b0ba
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 0 deletions.
diff --git a/.changeset/lazy-squids-unite.md b/.changeset/lazy-squids-unite.md
@@ -0,0 +1,5 @@
+---
+"@ima/plugin-testing-integration": patch
+---
+
+Fix support for Node 19+, which encounters `TypeError: Failed to execute 'dispatchEvent' on 'EventTarget': parameter 1 is not of type 'Event'.`. As a hotfix, we are now replacing `global.CustomEvent` (which comes with Node 19) with jsdom version of `CustomEvent` to keep the same behavior as in Node 18.
diff --git a/packages/plugin-testing-integration/src/app.js b/packages/plugin-testing-integration/src/app.js
@@ -86,6 +86,11 @@ async function initImaApp(bootConfigMethods = {}) {
       ...Object.getOwnPropertyDescriptors(global),
     });
 
+    // @TODO: The way we copy `window` properties to `global` is not correct,
+    // we should switch to `global-jsdom`, or take its implementation
+    // as an inspiration for our own implementation
+    global.CustomEvent = window.CustomEvent; // Hotfix for Node 19+, we can remove this once we switch to `global-jsdom`
+
     // set debug before IMA env debug
     global.$Debug = true;