Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix search. Now it will only return a daemon pointer if it is live #72

Merged
merged 1 commit into from
May 24, 2021

Conversation

stew3254
Copy link
Contributor

Fix Search of Unix systems. According to the docs for os.FindProcess(pid) this will never be nil even when I process doesn't exist.

On Unix systems, FindProcess always succeeds and returns a Process for the given pid, regardless of whether the process exists.

@codecov
Copy link

codecov bot commented Feb 27, 2021

Codecov Report

Merging #72 (ddc0bfd) into master (bf83969) will decrease coverage by 1.53%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #72      +/-   ##
==========================================
- Coverage   15.89%   14.35%   -1.54%     
==========================================
  Files          10        8       -2     
  Lines         258      209      -49     
==========================================
- Hits           41       30      -11     
+ Misses        212      174      -38     
  Partials        5        5              
Impacted Files Coverage Δ
daemon_unix.go 0.00% <0.00%> (ø)
lock_file.go 58.97% <0.00%> (-5.61%) ⬇️
lock_file_unix.go 75.00% <0.00%> (-5.00%) ⬇️
signal.go 7.14% <0.00%> (-2.39%) ⬇️
daemon.go 0.00% <0.00%> (ø)
command.go 0.00% <0.00%> (ø)
syscall_dup_pre17.go 0.00% <0.00%> (ø)
os_executable_pre18.go 0.00% <0.00%> (ø)
os_executable.go
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bf83969...ddc0bfd. Read the comment docs.

@deniszh
Copy link
Collaborator

deniszh commented May 24, 2021

Looks legit - golang/go#34396

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants