[BugFix] Fix pindex read/write confilict when enable pindex rebuild i…

…n compaction (StarRocks#37197)

Why I'm doing:

This bug is introduced by this pr(StarRocks#36819), we will rebuild pindex if we pick all rowsets to do compaction. But in rebuild pindex, we try to reset pindex but doesn't hold the lock which may cause read/write conflict between compaction and data ingestion.

What I'm doing:

Hold the primary index lock when we reset primary index.

Signed-off-by: zhangqiang <[email protected]>

be/src/storage/primary_index.cpp

@@ -1411,6 +1411,7 @@ Status PrimaryIndex::major_compaction(Tablet* tablet) {
 }
 
 Status PrimaryIndex::reset(Tablet* tablet, EditVersion version, PersistentIndexMetaPB* index_meta) {
+    std::lock_guard<std::mutex> lg(_lock);
     _table_id = tablet->belonged_table_id();
     _tablet_id = tablet->tablet_id();
     const TabletSchema& tablet_schema = tablet->tablet_schema();