Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hiroshiba
commented
Jan 14, 2024
| import { isMac } from "@/type/preload"; | ||
|
|
||
| const createUseKey = (key: string) => (): Ref<boolean> => { | ||
| // FIXME: Vue3.3以上では定義済みなので削除する |
|
|
||
| type Target = EventTarget & GlobalEventHandlers; | ||
|
|
||
| const useCreateUseKey = ( |
There was a problem hiding this comment.
コンポーザブルを作る関数はちょっと合法か怪しかったのでコンポーザブルに変えてみました。
（たぶん今のとこ合法）
|
|
||
| const useCreateUseKey = ( | ||
| key: string, | ||
| _target: MaybeRefOrGetter<Target> = window |
Comment on lines
+43
to
+47
| onUnmounted(() => { | ||
| target.removeEventListener("keydown", onKeydown); | ||
| target.removeEventListener("keyup", onKeyup); | ||
| target.removeEventListener("blur", onBlur); | ||
| }); |
There was a problem hiding this comment.
ベストプラクティスで「後処理もしましょう」みたいなことがVueUseに書いてたので。
Comment on lines
66
to
+69
| if (isMac) { | ||
| return useMetaKey(); | ||
| return useMetaKey(target); | ||
| } | ||
| return useControlKey(); | ||
| return useControlKey(target); |
There was a problem hiding this comment.
ifのなかでcomposable実行するのは今のとこ合法っぽい。
（今のVueコンポーネントがどれかさえ追えればなんでも良い）
Comment on lines
+12
to
+19
| const mountWrapper = (func: (elem: HTMLElement) => Ref<boolean>) => | ||
| mount({ | ||
| setup: () => { | ||
| const elem = document.createElement("div"); | ||
| return { elem, isActive: func(elem) }; | ||
| }, | ||
| render: () => null, // 警告防止 | ||
| }); |
sevenc-nanashi
approved these changes
Jan 15, 2024
といってもVueのコンポーザブルのとこにちょっと書いてるくらいなんですけどね。 あ、これ @sevenc-nanashi さんのリポジトリへのプルリクなので、マージしていただければ @sevenc-nanashi さんのプルリクに反映されると思います！ |
|
（マージ忘れてました） |
sevenc-nanashi
merged commit 53e1e12
into
sevenc-nanashi:fix/multi-select-with-unfocus
7 checks passed
sevenc-nanashi
added a commit
that referenced
this pull request
Jan 16, 2024
* Refactor: 修飾キーのcomposableを追加 * Dlete: 不要なexportを削除 Co-authored-by: Hiroshiba <[email protected]> * #1711のテスト書いてみた (#1) --------- Co-authored-by: Hiroshiba <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
内容
VOICEVOX#1711 のテストを書いてみました。
めちゃくちゃ難しかったです。。。。。。。
その他