Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Time of Day rules are off by 1hr (due to daylight savings time ending?) #146

Closed
slpy9 opened this issue Apr 9, 2023 · 4 comments
Closed

Comments

@slpy9
Copy link

slpy9 commented Apr 9, 2023

I've just noticed my access control rules are not handling daylight savings time correctly.

We've (AEST) recently gone off DST time, winding our clocks back 1 hour, the router display's the correct time in the system info panel.. but any time of day rules I have active are starting and ending 1hr earlier than they should.

For example, I have access rules starting at midnight and ending at 8am, which are instead starting at 11pm and ending at 7am.

Firmware Version 20.3.c.0432-MR21-RA
tch-gui-unhide 2023.03.23@17:06
Model Technicolor DJA0231
@seud0nym
Copy link
Owner

Can you run this command, and let me know tomorrow if it has fixed it?

date -k

(There is no output from that command.)

@slpy9
Copy link
Author

slpy9 commented Apr 10, 2023

I've just done some short tests with 15min on/off rules and that appears to have fixed it.

Thanks!

@seud0nym
Copy link
Owner

Thanks for confirming the fix.

The problem is that the time of day processing uses the kernel time zone, rather than the system time zone, and the kernel time zone is only set on boot (or by date -k),

I can't see any work-around except to schedule a task that will run to update the kernel time zone. I will add that to the next release.

@seud0nym seud0nym added the pending release Fixed but pending next release label May 3, 2023
@seud0nym seud0nym removed the pending release Fixed but pending next release label May 16, 2023
@seud0nym
Copy link
Owner

Fixed in release 2023.05.16

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants