Expose Action.Getenv #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sorry, I don't understand the request here. You have a getenv func, why not call that directly? |
|
I do that: https://github.com/FerretDB/github-actions/blob/e34bef95940ca0d735069846e840f4e0aacddfc9/extract-docker-tag/main.go#L38-L40 |
sethvargo
approved these changes
Feb 9, 2022
| @@ -405,6 +405,11 @@ func (c *Action) GetIDToken(ctx context.Context, audience string) (string, error | |||
| return tokenResp.Value, nil | |||
| } | |||
|
|
|||
| // Getenv retrieves the value of the environment variable named by the key. | |||
There was a problem hiding this comment.
Can you document that it uses the internal Getenv function?
There was a problem hiding this comment.
Done, added the second line to this comment
This commit makes `Action.getenv` accessible without making it settable without using `WithGetenv`. That allows tests with a fake environment to pass only Action.
|
Do you want me to cut a release, or do you have some other PRs up your sleeve? |
|
Nope, nothing today :) Thank you! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit makes
Action.getenvaccessible without making it settable without usingWithGetenv. That allows tests with a fake environment to pass only Action.For example, there I have to pass both Action and a fake getenv function to the function I want to test: https://github.com/FerretDB/github-actions/blob/e34bef95940ca0d735069846e840f4e0aacddfc9/extract-docker-tag/main_test.go#L11-L39