Enable disabling hostname verification for macOS and Windows #152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sethmlarson
force-pushed
the
macos-set-hostname-only-when-verifying
branch
from
dead3d2
to
fdcb7aa
Compare
sethmlarson
changed the title
sethmlarson
force-pushed
the
macos-set-hostname-only-when-verifying
branch
from
3599718
to
197ed07
Compare
sethmlarson
force-pushed
the
macos-set-hostname-only-when-verifying
branch
from
197ed07
to
ca375dd
Compare
davisagli
approved these changes
Oct 23, 2024
|
Will this trigger a release? |
|
@achapkowski 0.10.0 is available on PyPI! :) |
|
Awesome thank you again |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently we "disable" hostname verification on macOS by ignoring a hostname mismatch error. Instead we can not set a policy to check the hostname, then we don't need to ignore any errors for this functionality.
For Windows, instead of ignoring all name errors for certificates we can ignore only a mismatch.