-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Re-use http.Request #42
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hods and status codes, fix typos in sample
constants for pester methods, http package constants for standart met…
…y logical flow. PostForm = Post.
sethgrid
approved these changes
Jun 15, 2020
@groovili Thanks for making a PR! Looks like there are merge conflicts that need to be resolved first. |
@sethgrid resolved :) |
Looks like a missing end-quote. After I added the missing end-quote:
Looks like there is still some work to be done. |
@sethgrid Sorry, my bad. Did small change after checking tests. |
sethgrid
approved these changes
Jun 17, 2020
Thanks for the PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
I've added small optimization and modules support.
The main idea is to re-use
http.Request
created fromparams
or provided directly and re-create onlyrequest.Body
fromoriginalBody
for retries.This change simplifies flow.
Also I've changed
PostForm
because it's mostly the same asPost
and can be handled with inputparams
without additional logic.Tests are passing and no breaking changes.