Fix typo in test #30
Merged
Fix typo in test #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sethgrid
reviewed
Feb 27, 2018
| @@ -152,7 +152,7 @@ func TestCustomLogHook(t *testing.T) { | |||
|
|
|||
| // in the event of an error, let's see what the logs were | |||
| if expectedRetries != len(errorLines) { | |||
| t.Errorf("Expected %d lines to be emitted. Got %d", expectedRetries, errorLines) | |||
| t.Errorf("Expected %d lines to be emitted. Got %d", expectedRetries, len(errorLines)) | |||
There was a problem hiding this comment.
errorLines := []ErrEntry{}
The current test, with the %d, is just saying "hey, these numbers don't match."
If you want to see the actual individual ErrEntry values, we would have to change %d to %v. By keeping the %d, I would expect the fmt statement to say something like:
Expected 3 lines to be emitted. Got %!d(ErrEntry=something)
There was a problem hiding this comment.
Without this fix, I get the following failure:
_/Users/raj/pester
./pester_test.go:155: Errorf format %d has arg errorLines of wrong type []pester.ErrEntry
FAIL _/Users/raj/pester [build failed]
There was a problem hiding this comment.
doh! I totally read it backwards (facepalm).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.