Port NonZero optimization to stable Rust #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SimonSapin
force-pushed
the
…
branch
2 times, most recently
from
2bccc2b
to
2ad796d
Compare
emilio
approved these changes
Jun 29, 2017
src/util.rs
Outdated
| impl NonZeroUsize { | ||
| #[inline] | ||
| pub unsafe fn new(value: usize) -> Self { | ||
| NonZeroUsize(&*(value as *const u8)) |
There was a problem hiding this comment.
core::nonzero::NonZero doesn’t, but sure. Done.
|
@bors-servo r+ |
|
📌 Commit 8d80121 has been approved by |
bors-servo
pushed a commit
that referenced
this pull request
Jun 29, 2017
Port NonZero optimization to stable Rust … and various drive-by fixes. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/tendril/33) <!-- Reviewable:end -->
|
☀️ Test successful - status-travis |
bors-servo
pushed a commit
to servo/html5ever
that referenced
this pull request
Jun 30, 2017
"unstable" Cargo features are now no-ops, to be removed. servo/tendril#33 <!-- Reviewable:start --> This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/html5ever/284) <!-- Reviewable:end -->
bors-servo
pushed a commit
to servo/html5ever
that referenced
this pull request
Jul 1, 2017
"unstable" Cargo features are now no-ops, to be removed. servo/tendril#33 <!-- Reviewable:start --> This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/html5ever/284) <!-- Reviewable:end -->
bors-servo
pushed a commit
to servo/html5ever
that referenced
this pull request
Jul 1, 2017
"unstable" Cargo features are now no-ops, to be removed. servo/tendril#33 <!-- Reviewable:start --> This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/html5ever/284) <!-- Reviewable:end -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… and various drive-by fixes.
This change is