servo: Add support for parsing :is(), :has(), :where(), and nesting selectors
#80
+20
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ting selectors Stylo supports these and they just need to be turned on. Signed-off-by: Martin Robinson <[email protected]>
nicoburns
approved these changes
Sep 25, 2024
There was a problem hiding this comment.
Looks good. We've done this in Blitz and it seems to work. My one reservation would be that I believe that "nth-child" and "has" require extra invalidation logic that is not handled by Stylo and needs to be handled externally.
(I am keen to document how that works, probably as an example in the Stylo repo, but I haven't worked it out myself yet)
|
Yeah have you confirmed that |
It's functional, but there's still work to do with invalidation, as @nicoburns mentioned above. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stylo supports these and they just need to be turned on.
Signed-off-by: Martin Robinson [email protected]