Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable min-content, max-content, fit-content and stretch #79

Merged
merged 1 commit into from
Sep 20, 2024
Merged

Enable min-content, max-content, fit-content and stretch #79

merged 1 commit into from
Sep 20, 2024

Conversation

Loirooriol
Copy link
Contributor

For the sizing properties.

@Loirooriol @mrobinson
Enable min-content, max-content, fit-content and stretch
3ee523d 
For the sizing properties.

Co-authored-by: Martin Robinson <[email protected]>
Signed-off-by: Oriol Brufau <[email protected]>
@nicoburns
Copy link
Contributor

nicoburns commented Sep 18, 2024 •
edited
Loading

Should the remaining variants (MozAvailable, WebkitFillAvailable, and FitContentFunction(_)) also be enabled? I believe MozAvailable and WebkitFillAvailable are just non-standard aliases for Stretch (which hasn't shipped under the standardised name in any major browser yet), and FitContentFunction(_) shouldn't add much complexity on top of an implementation for MinContent and MaxContent.

@Loirooriol
Copy link
Contributor Author

We thought we would start with the basic ones, and think about others later.

@Loirooriol Loirooriol added this pull request to the merge queue Sep 20, 2024
Merged via the queue into servo:main with commit dd8d32c Sep 20, 2024
3 checks passed
@Loirooriol Loirooriol deleted the intrinsic-size-keywords branch September 20, 2024 14:11
Loirooriol added a commit to Loirooriol/stylo that referenced this pull request Oct 5, 2024
@Loirooriol
Enable stretch keyword
e9f14eb 
In servo#79 we forgot to set the relevant pref to true.
We will be adding support for these sizing keywords in Servo, so better
enable it so that we can test that it works well.

Signed-off-by: Oriol Brufau <[email protected]>
@Loirooriol Loirooriol mentioned this pull request Oct 5, 2024
Merged
github-merge-queue bot pushed a commit that referenced this pull request Oct 5, 2024
@Loirooriol
Enable stretch keyword (#81)
a8cc501 
In #79 we forgot to set the relevant pref to true.
We will be adding support for these sizing keywords in Servo, so better
enable it so that we can test that it works well.

Signed-off-by: Oriol Brufau <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrobinson mrobinson mrobinson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Loirooriol @nicoburns @mrobinson