Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add CI for a 32-bit platform #162

Open
nox opened this issue May 27, 2016 · 2 comments
Open

Add CI for a 32-bit platform #162

nox opened this issue May 27, 2016 · 2 comments

Comments

@nox
Copy link
Contributor

nox commented May 27, 2016

No description provided.

@nabijaczleweli
Copy link

Can this also be verified by installing a 32-bit rustc (e.g. via rustup.rs)?

SimonSapin added a commit that referenced this issue Oct 25, 2016
@SimonSapin
Make tests pass on a 32-bit system.
f0571b6 
Testable on 64-bit Linux with:

```
rustup target add i686-unknown-linux-gnu
cargo test --target i686-unknown-linux-gnu
```

Assuming a linker and libc for this target are available on the system.

Leaving #162 to add this to CI.
(Unfortunately Travis doesn’t use rustup out of the box.)
SimonSapin added a commit that referenced this issue Oct 25, 2016
@SimonSapin
Make tests pass on a 32-bit system.
c376bb7 
Testable on 64-bit Linux with:

```
rustup target add i686-unknown-linux-gnu
cargo test --target i686-unknown-linux-gnu
```

Assuming a linker and libc for this target are available on the system.

Leaving #162 open to add CI for this.
(Unfortunately Travis doesn’t use rustup out of the box.)
SimonSapin added a commit that referenced this issue Oct 25, 2016
@SimonSapin
Make tests pass on a 32-bit system.
40d8629 
Testable on 64-bit Linux with:

```
rustup target add i686-unknown-linux-gnu
cargo test --target i686-unknown-linux-gnu
```

(or similarly on anther 64-bit platforms),
assuming a linker and libc for this target are available on the system.

Leaving #162 open to add CI for this.
(Unfortunately Travis doesn’t use rustup out of the box.)
@SimonSapin SimonSapin mentioned this issue Oct 25, 2016
Merged
bors-servo pushed a commit that referenced this issue Oct 25, 2016
Auto merge of #176 - servo:32, r=emilio
7379d87 
Make tests pass on a 32-bit system.

Testable on 64-bit Linux with:

```
rustup target add i686-unknown-linux-gnu
cargo test --target i686-unknown-linux-gnu
```

(or similarly on anther 64-bit platforms), assuming a linker and libc for this target are available on the system.

Leaving #162 open to add CI for this. (Unfortunately Travis doesn’t use rustup out of the box.)

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/string-cache/176)
<!-- Reviewable:end -->
@SimonSapin
Copy link
Member

SimonSapin commented Oct 25, 2016 •
edited
Loading

#176 makes tests pass. We still need CI:

  • Get rustup.rs in our Travis environment somehow, and the gcc-multilib Ubuntu package
  • rustup target add i686-unknown-linux-gnu
  • cargo test --target i686-unknown-linux-gnu

@SimonSapin SimonSapin changed the title Check that the tests pass in a 32 bits system Add CI for a 32-bit platform Oct 25, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@nox @SimonSapin @nabijaczleweli