Skip to content

Conversation

@jdm
Copy link
Member

@jdm jdm commented May 18, 2018

This is causing us to hit a mac bug in rustc that I'm still tracking down and ruining our ability to merge PRs. This works around #20756 until the problem is fixed upstream.


This change is Reviewable

@highfive
Copy link

warning Warning warning

  • These commits modify gfx code, but no tests are modified. Please consider adding a test!

@highfive highfive added the S-awaiting-review There is new code that needs to be reviewed. label May 18, 2018
@jdm
Copy link
Member Author

jdm commented May 18, 2018

@bors-servo p=1000 r+

@bors-servo
Copy link
Contributor

📌 Commit e797938 has been approved by jdm

@highfive highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-awaiting-review There is new code that needs to be reviewed. labels May 18, 2018
@highfive highfive assigned jdm and unassigned Manishearth May 18, 2018
@jdm
Copy link
Member Author

jdm commented May 18, 2018

rust-lang/rust#50867

@bors-servo
Copy link
Contributor

⌛ Testing commit e797938 with merge d6c26af...

bors-servo pushed a commit that referenced this pull request May 18, 2018
Revert "Upgrade to rustc 1.27.0-nightly (8a37c75a3 2018-05-02)"

This is causing us to hit a mac bug in rustc that I'm still tracking down and ruining our ability to merge PRs. This works around #20756 until the problem is fixed upstream.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20820)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, windows-msvc-dev
Approved by: jdm
Pushing d6c26af to master...

@bors-servo bors-servo merged commit e797938 into servo:master May 18, 2018
@highfive highfive removed the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label May 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants