Turn on unused-extern-crates warning. #10706
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the pull request, and welcome! The Servo team is excited to review your changes, and you should hear from @nox (or someone else) soon. |
|
Heads up! This PR modifies the following files:
|
highfive
added
the
S-awaiting-review
|
We might want to wait? |
|
@bors-servo try Code looks fine, but let's run it through CI to see how many false positives we get. Reviewed 1 of 1 files at r1. Comments from Reviewable |
bors-servo
pushed a commit
that referenced
this pull request
Apr 19, 2016
Turn on unused-extern-crates warning. As discussed in #9256. It should solve second half of the issue. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/10706) <!-- Reviewable:end -->
|
💔 Test failed - mac-rel-wpt |
|
|
I have added guards to the false positives. What is left should be the actual thing. |
|
The last commit takes care of the unused crates. I think am all done here (unless you have some suggestions). |
|
|
|
I'll fold it into the false positives commit then. |
|
@Ms2ger Done. |
nox
added
S-needs-squash
|
Please squash the commits together, a bisection ending up in the middle of your PR would have failing tests. -S-awaiting-review +S-needs-squash Reviewed 1 of 1 files at r1, 5 of 8 files at r2, 1 of 1 files at r3, 18 of 19 files at r4, 1 of 1 files at r5. Comments from Reviewable |
|
Rather than squashing, I'd suggest reordering the commits so that the "Turn on unused-extern-crates warning." comes after the two other commits. |
highfive
added
the
S-awaiting-review
|
Reorder done. |
|
@bors-servo r+ |
|
📌 Commit 99e6ada has been approved by |
highfive
added
S-awaiting-merge
bors-servo
pushed a commit
that referenced
this pull request
Apr 22, 2016
Turn on unused-extern-crates warning. As discussed in #9256. It should solve second half of the issue. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/10706) <!-- Reviewable:end -->
|
I have folded the update of the lock files into the commit modifying the toml files (hope that is ok). |
|
@bors-servo r+ |
|
📌 Commit 2207830 has been approved by |
highfive
added
S-awaiting-merge
bors-servo
pushed a commit
that referenced
this pull request
Apr 22, 2016
Turn on unused-extern-crates warning. As discussed in #9256. It should solve second half of the issue. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/10706) <!-- Reviewable:end -->
|
💔 Test failed - android |
highfive
added
S-tests-failed
|
Can anyone help with the android stuff? I don't have the environment set up and I know close to nothing about android. I guess some of the extern crates should have been guarded by cfg(android). |
|
Yes, that would be the correct way to sort it out. Specifically, the use of the |
Added #[allow(unused_extern_crates)] to silence false positives * bitflags, lazy_static and matches because macro_use * alloc_jemalloc because builtin crate See rust-lang/rust#30849
The cleanup is based on info from using "-W unused-extern-crates".
highfive
added
S-awaiting-review
|
Reworked to consider also android build. |
|
@bors-servo: r=nox |
|
📌 Commit 4bdc895 has been approved by |
highfive
added
S-awaiting-merge
bors-servo
pushed a commit
that referenced
this pull request
Apr 22, 2016
Turn on unused-extern-crates warning. As discussed in #9256. It should solve second half of the issue. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/10706) <!-- Reviewable:end -->
|
☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel, mac-dev-unit, mac-rel-css, mac-rel-wpt |
highfive
removed
the
S-awaiting-merge
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #9256. It should solve second half of the issue.
This change is