Skip to content

Conversation

@mbrubeck
Copy link
Collaborator

No description provided.

@mbrubeck mbrubeck requested review from Manishearth and jdm June 17, 2023 00:10
@mbrubeck
Copy link
Collaborator Author

Notable changes include #292 and #298. Some additional eyes on those changes might be good before we release this.

After this is released, I'd like to make #284 the main branch, and begin preparing for smallvec 2.0.

Copy link
Member

@Manishearth Manishearth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me for the version bump, haven't looked too closely at the other changes

@the8472
Copy link

the8472 commented Jul 1, 2023

Note that DrainFilter in std has been replaced with ExtractIf which doesn't keep draining on drop.

@mbrubeck
Copy link
Collaborator Author

mbrubeck commented Jul 5, 2023

Note that DrainFilter in std has been replaced with ExtractIf which doesn't keep draining on drop.

Thanks for the heads-up. We can add this new API behind a separate feature if someone has time to implement it, and we can drop the old API in version 2.0.

@mbrubeck mbrubeck merged commit 82b5f5b into servo:master Jul 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants