Add support for * prefix in declaration names #388
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emilio
requested changes
Nov 7, 2024
| @@ -211,6 +211,10 @@ where | |||
| hex_escape(digit, dest)?; | |||
| value = &value[1..]; | |||
| } | |||
| if b'*' == value.as_bytes()[0] { | |||
There was a problem hiding this comment.
This is not correct, this is not an identifier.
|
Yes, this needs a redo with correct method and comprehensive tests. I can do the changes if you are interested in having this feature. |
|
I don't think we're particularly interested in it, if some tooling needs it we could accept it I guess but... That said, I wonder if this could be implemented on top of cssparser too without changes (basically, on the error code path, try to consume the asterisk + ident + colon) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey
This is a hacky fix for adding support of legacy
*prefixes tocssparser.Currently this fails to be parsed:
And there is a good reason to it, This legacy syntax is only used for ie 6/7 and it's not valid css3 grammar too.
But some libraries and old codebases still depend on this kind of properties to work on old browsers.
I know this is not a correct way to do it, but if you have plans to add this feature to parser, i can prepare another fix that uses feature-gates in cargo.toml and has proper parsing methods for handling this kind of syntax.