This repository was archived by the owner on Mar 20, 2024. It is now read-only.
Add an env var for cmake generator #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I declare this unobjectionable. |
|
📌 Commit 2661d55 has been approved by |
bors-servo
pushed a commit
that referenced
this pull request
Dec 12, 2018
Add an env var for cmake generator Some discussion in rust-lang/cmake-rs#66, it's not clear to me what the best solution is yet but I'm putting up this patch here anyway. It certainly solves my issue and unblocks me, so please feel free to merge this if it's acceptable. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/libfreetype2/28) <!-- Reviewable:end -->
|
☀️ Test successful - status-travis |
staktrace
added a commit
to staktrace/webrender
that referenced
this pull request
Dec 13, 2018
This picks up servo/libfreetype2#28 which is desirable for building pathfinder as part of webrender in Firefox CI on Windows.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some discussion in rust-lang/cmake-rs#66, it's not clear to me what the best solution is yet but I'm putting up this patch here anyway. It certainly solves my issue and unblocks me, so please feel free to merge this if it's acceptable.
This change is