Skip to content
This repository has been archived by the owner on Feb 17, 2023. It is now read-only.

Fix intermittent build error #42

Merged
merged 2 commits into from
Dec 5, 2019
Merged

Fix intermittent build error #42

merged 2 commits into from
Dec 5, 2019

Conversation

jdm
Copy link
Member

@jdm jdm commented Dec 5, 2019

This is a symptom of a change in Cargo (rust-lang/cargo#7465) that no longer preserves the mtime of files extracted during the package download process. This means that generated files included in this repository can end up being regenerated unnecessarily unless we explicitly force them to be treated as more recent than their source files.

@asajeffrey
Copy link
Member

@bors-servo r+

@bors-servo
Copy link
Contributor

📌 Commit e02e81c has been approved by asajeffrey

bors-servo pushed a commit that referenced this pull request Dec 5, 2019
Fix intermittent build error

This is a symptom of a change in Cargo (rust-lang/cargo#7465) that no longer preserves the mtime of files extracted during the package download process. This means that generated files included in this repository can end up being regenerated unnecessarily unless we explicitly force them to be treated as more recent than their source files.
@bors-servo
Copy link
Contributor

⌛ Testing commit e02e81c with merge 38e028e...

@bors-servo
Copy link
Contributor

☀️ Test successful - checks-travis
Approved by: asajeffrey
Pushing 38e028e to master...

@bors-servo bors-servo merged commit e02e81c into master Dec 5, 2019
bors-servo pushed a commit to servo/servo that referenced this pull request Dec 9, 2019
Fix intermittent android build error

Incorporates servo/libfontconfig#42.

- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #24715
- [x] There are tests for these changes
bors-servo pushed a commit to servo/servo that referenced this pull request Dec 9, 2019
Fix intermittent android build error

Incorporates servo/libfontconfig#42.

- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #24715
- [x] There are tests for these changes
bors-servo pushed a commit to servo/servo that referenced this pull request Dec 9, 2019
Fix intermittent android build error

Incorporates servo/libfontconfig#42.

- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #24715
- [x] There are tests for these changes
bors-servo pushed a commit to servo/servo that referenced this pull request Dec 9, 2019
Fix intermittent android build error

Incorporates servo/libfontconfig#42.

- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #24715
- [x] There are tests for these changes
bors-servo pushed a commit to servo/servo that referenced this pull request Dec 9, 2019
Fix intermittent android build error

Incorporates servo/libfontconfig#42.

- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #24715
- [x] There are tests for these changes
xeonchen pushed a commit to xeonchen/gecko that referenced this pull request Mar 10, 2020
moz-v2v-gh pushed a commit to mozilla/gecko-dev that referenced this pull request Mar 11, 2020
… errors. r=kvark

The lack of servo/libfontconfig#42 in 4.0.4
broke rust CI

Differential Revision: https://phabricator.services.mozilla.com/D66275

--HG--
extra : moz-landing-system : lando
moz-gfx pushed a commit to moz-gfx/webrender that referenced this pull request Mar 11, 2020
gecko-dev-updater pushed a commit to marco-c/gecko-dev-comments-removed that referenced this pull request Mar 12, 2020
… errors. r=kvark

The lack of servo/libfontconfig#42 in 4.0.4
broke rust CI

Differential Revision: https://phabricator.services.mozilla.com/D66275

UltraBlame original commit: 399aeed6f2c4f1e4300b3a11ee740464e0e0d5c3
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified that referenced this pull request Mar 12, 2020
… errors. r=kvark

The lack of servo/libfontconfig#42 in 4.0.4
broke rust CI

Differential Revision: https://phabricator.services.mozilla.com/D66275

UltraBlame original commit: 399aeed6f2c4f1e4300b3a11ee740464e0e0d5c3
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified-and-comments-removed that referenced this pull request Mar 12, 2020
… errors. r=kvark

The lack of servo/libfontconfig#42 in 4.0.4
broke rust CI

Differential Revision: https://phabricator.services.mozilla.com/D66275

UltraBlame original commit: 399aeed6f2c4f1e4300b3a11ee740464e0e0d5c3
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants