Bump xml5ever, markup5ever and html5ever versions #592
+8
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdm
requested changes
Apr 5, 2025
Member
jdm
left a comment
jdm
left a comment
There was a problem hiding this comment.
You will need to update https://github.com/servo/html5ever/blob/main/rcdom/Cargo.toml#L19, as well as the markup5ever dependencies in xml5ever and html5ever.
This should have been done as part of servo#591. I forgot that servo depends on the crates.io version of html5ever, not the git repository. So to upgrade in servo we need to release new versions of all three crates. Signed-off-by: Simon Wülker <[email protected]>
simonwuelker
force-pushed
the
bump-versions
branch
from
cb0151a to
2841d9b
Compare
Contributor
Author
|
Oops, sorry... |
jdm
approved these changes
Apr 5, 2025
Member
|
Published. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should have been done as part of #591. I forgot that servo depends on the crates.io version of html5ever, not the git repository. So to upgrade in servo we need to release new versions of all three crates.
All three crates have received breaking changes since the last PR.
cc @mrobinson since I think you have permission to create new releases?