Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ambiguity of glob import with matches! now in the standard library #402

Merged
merged 1 commit into from
Oct 25, 2019
Merged

Fix ambiguity of glob import with matches! now in the standard library #402

merged 1 commit into from
Oct 25, 2019

Conversation

SimonSapin
Copy link
Member 

error[E0659]: `matches` is ambiguous (glob import vs any other name from outer scope during import/macro resolution)
   --> html5ever/src/tree_builder/tag_sets.rs:109:5
    |
109 |     matches!(
    |     ^^^^^^^ ambiguous name
    |
    = note: `matches` could refer to a macro from prelude
note: `matches` could also refer to the macro imported here
   --> html5ever/src/tree_builder/tag_sets.rs:13:5
    |
13  | use mac::*;
    |     ^^^^^^
    = help: consider adding an explicit import of `matches` to disambiguate
    = help: or use `self::matches` to refer to this macro unambiguously

error: aborting due to 2 previous errors

@SimonSapin
Fix ambiguity of glob import with matches! now in the standard library
c7691e9 
```
error[E0659]: `matches` is ambiguous (glob import vs any other name from outer scope during import/macro resolution)
   --> html5ever/src/tree_builder/tag_sets.rs:109:5
    |
109 |     matches!(
    |     ^^^^^^^ ambiguous name
    |
    = note: `matches` could refer to a macro from prelude
note: `matches` could also refer to the macro imported here
   --> html5ever/src/tree_builder/tag_sets.rs:13:5
    |
13  | use mac::*;
    |     ^^^^^^
    = help: consider adding an explicit import of `matches` to disambiguate
    = help: or use `self::matches` to refer to this macro unambiguously

error: aborting due to 2 previous errors
```
@SimonSapin SimonSapin mentioned this pull request Oct 25, 2019
Closed
@nox
Copy link
Contributor

nox commented Oct 25, 2019

@bors-servo r+

@bors-servo
Copy link
Contributor

📌 Commit c7691e9 has been approved by nox

@bors-servo
Copy link
Contributor

⌛ Testing commit c7691e9 with merge 010c277...

bors-servo pushed a commit that referenced this pull request Oct 25, 2019
Auto merge of #402 - servo:glob, r=nox
010c277 
Fix ambiguity of glob import with `matches!` now in the standard library

```rust
error[E0659]: `matches` is ambiguous (glob import vs any other name from outer scope during import/macro resolution)
   --> html5ever/src/tree_builder/tag_sets.rs:109:5
    |
109 |     matches!(
    |     ^^^^^^^ ambiguous name
    |
    = note: `matches` could refer to a macro from prelude
note: `matches` could also refer to the macro imported here
   --> html5ever/src/tree_builder/tag_sets.rs:13:5
    |
13  | use mac::*;
    |     ^^^^^^
    = help: consider adding an explicit import of `matches` to disambiguate
    = help: or use `self::matches` to refer to this macro unambiguously

error: aborting due to 2 previous errors
```
@bors-servo
Copy link
Contributor

☀️ Test successful - checks-travis
Approved by: nox
Pushing 010c277 to master...

@bors-servo bors-servo merged commit c7691e9 into master Oct 25, 2019
@SimonSapin SimonSapin deleted the glob branch October 25, 2019 08:40
SimonSapin added a commit that referenced this pull request Oct 25, 2019
@SimonSapin
Bump version numbers for #402
716fcf9
SimonSapin added a commit to servo/servo that referenced this pull request Oct 25, 2019
@SimonSapin
Update html5ever and xml5ever
533e2d6 
Pick up servo/html5ever#402
@SimonSapin SimonSapin mentioned this pull request Oct 25, 2019
Merged
bors-servo pushed a commit to servo/servo that referenced this pull request Oct 25, 2019
Auto merge of #24550 - servo:rustup_, r=nox
11eacfa 
Update html5ever and xml5ever

Pick up servo/html5ever#402
bors-servo pushed a commit to servo/servo that referenced this pull request Oct 25, 2019
Auto merge of #24550 - servo:rustup_, r=nox
2dddbad 
Update html5ever and xml5ever

Pick up servo/html5ever#402
@SimonSapin SimonSapin mentioned this pull request Nov 21, 2019
Closed
@KamilaBorowska KamilaBorowska mentioned this pull request Jan 21, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SimonSapin @nox @bors-servo