Enable debugging information in dev and test builds. #346
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This only makes a difference when compiling from the source repository (when the modified Either way, yes doing this is overdue :) @bors-servo r+ |
|
📌 Commit 3a12b42 has been approved by |
bors-servo
pushed a commit
that referenced
this pull request
Jul 1, 2018
Enable debugging information in dev and test builds. It's pretty surprising when tests and dev builds can't be debugged. Debugging information was disabled in 1223b23 (2015-3-31) because of rust-lang/rust#23110, which was closed 2016-7-14. It should be okay to turn it back on now.
|
☀️ Test successful - status-travis |
Yes, that's correct. There are no customizations to the dev or test profiles that I saw in the crates' Cargo.toml files. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's pretty surprising when tests and dev builds can't be debugged. Debugging information was disabled in 1223b23 (2015-3-31) because of rust-lang/rust#23110, which was closed 2016-7-14. It should be okay to turn it back on now.