Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to rustc 1.0.0-nightly (c89de2c56 2015-03-28) (built 2015-03-29) #116

Closed
wants to merge 2 commits into from

Conversation

Ogeon
Copy link
Contributor

@Ogeon Ogeon commented Mar 28, 2015

Removed a few deprecated things, such as a bunch of as_slice. I decided to let most of the char_at and friends stay for a little longer.

The tests are, once again, experiencing the #23110 ICE and I'm not sure where it originates this time.

@Manishearth
Copy link
Member

Travis is ICEing :/

/me tries locally

@Ogeon
Copy link
Contributor Author

Ogeon commented Mar 28, 2015

Yes, as I said. I have the same ICE in my own project where I'm using html5ever. I have no Idea where it comes from. There are no multi line #![feature(...)].

@Manishearth
Copy link
Member

Oh, right. Hm

@@ -11,12 +11,12 @@
#![crate_type="dylib"]

#![feature(plugin_registrar, quote)]
#![feature(rustc_private, core, std_misc)]
#![feature(rustc_private, convert)]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm, are lines L13-L14 examples of multi-line feature?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried to change them. No difference. Besides, they are in the macro crate, which is built before the html5ever crate. I can still change it if it's desired.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Ogeon, I don't think the issue is necessarily with #![feature]. I've been hitting a similar bug, without using #![feature] at all and on older version of Rust. I suspect it's some underlying macro expansion error.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds reasonable.

@Ogeon Ogeon changed the title Upgrade to rustc 1.0.0-nightly (27901849e 2015-03-25) (built 2015-03-26) Upgrade to rustc 1.0.0-nightly (c89de2c56 2015-03-28) (built 2015-03-29) Mar 30, 2015
@Ogeon
Copy link
Contributor Author

Ogeon commented Mar 30, 2015

This is really strange... My project builds now, without any ICE, when using these fixes, but these tests are still failing. Nothing changed in my code.

@Ygg01
Copy link
Contributor

Ygg01 commented Mar 30, 2015

@Ogeon : Did you run the make check examples or make examples? That's what causes ICE for me 😢 ? The cargo build passes fine, but make examples fails horribly with ICE.

@Ogeon
Copy link
Contributor Author

Ogeon commented Mar 30, 2015

I did run make check and it failed, but I could successfully build symbiosis, where I'm using html5ever. That's what's odd.

@kmcallister
Copy link
Contributor

I think all these changes are on master now. I worked around the ICE building examples by disabling debug info.

@kmcallister kmcallister closed this Apr 2, 2015
@Ogeon
Copy link
Contributor Author

Ogeon commented Apr 2, 2015

Alright, thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants