-
Notifications
You must be signed in to change notification settings - Fork 223
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to rustc 1.0.0-nightly (c89de2c56 2015-03-28) (built 2015-03-29) #116
Conversation
Travis is ICEing :/ /me tries locally |
Yes, as I said. I have the same ICE in my own project where I'm using html5ever. I have no Idea where it comes from. There are no multi line |
Oh, right. Hm |
@@ -11,12 +11,12 @@ | |||
#![crate_type="dylib"] | |||
|
|||
#![feature(plugin_registrar, quote)] | |||
#![feature(rustc_private, core, std_misc)] | |||
#![feature(rustc_private, convert)] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hm, are lines L13-L14 examples of multi-line feature?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tried to change them. No difference. Besides, they are in the macro crate, which is built before the html5ever crate. I can still change it if it's desired.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Ogeon, I don't think the issue is necessarily with #![feature]
. I've been hitting a similar bug, without using #![feature]
at all and on older version of Rust. I suspect it's some underlying macro expansion error.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds reasonable.
This is really strange... My project builds now, without any ICE, when using these fixes, but these tests are still failing. Nothing changed in my code. |
@Ogeon : Did you run the |
I did run |
I think all these changes are on master now. I worked around the ICE building examples by disabling debug info. |
Alright, thanks. |
Removed a few deprecated things, such as a bunch of
as_slice
. I decided to let most of thechar_at
and friends stay for a little longer.The tests are, once again, experiencing the #23110 ICE and I'm not sure where it originates this time.