Fix handling of numpad keys w.r.t. numlock (derived from fix mentione… #22
Conversation
This was previously in glutin, but was removed since Weak is not marked stable here: rust-windowing@0f7bd90 Some X drivers crash if the window isn't closed from the main thread.
Fix a double free corruption crash in some X drivers on exit. r=mbrubeck
implement get_platform_window() return for X11
add ability to set parent window when creating windows
|
This should go upstream to https://github.com/tomaka/glutin, I think. |
|
I have a local branch of tomaka/glutin that I've cherry-picked the commit onto, but servo doesn't compile with that version of glutin. I have tested this branch with servo, and verified that it allows numbers to be entered into textboxes with the numpad. Should I PR the branch of tomaka/glutin/master, then do a seperate PR rebasing servo/glutin/servo onto tomaka/glutin/master (once the former is accepted)? |
|
I don't know what the current setup is; do you @larsbergstrom? |
|
Generally for forks of community projects we should always land upstream, and then cherry pick down to our fork. When the next rust upgrade happens, we'll be back on upstream master hopefully. We should probably be naming our fork branches servo-20YYMMDD so that this is clearer. |
|
@metajack We should probably talk at the meeting about this. We've been having trouble with landing changes required for CEF into upstream glutin due to differing design goals upstream and may end up with a fork. |
|
☔ The latest upstream changes (presumably rust-windowing#567) made this pull request unmergeable. Please resolve the merge conflicts. |
|
This went upstream so we're covered. |
…d at http://www.kaffe.org/pipermail/kaffe/2000-April/175201.html).