Implement actual support for no_std#372
Conversation
With num-traits having recently gained full support for no_std by using the libm crate, this crate can now fully support no_std as well without any sacrifices. Currently num-traits has not released a new version yet, so this uses a git dependency until then. Additionally the tests should fail at the moment when using the libm, as there actually was a bug in libm that I have created a PR for.
|
So this is done, but the one test fails because sincosf was broken in Rust's libm port. However this has since been fixed, but no new version of libm has been published. rust-lang/libm#229 Not sure how you want me to proceed here. |
|
Thanks! My preference would be to wait for the the new libm to be published and depend on the fixed revision in this PR. |
|
I filed rust-lang/libm#231 |
|
libm 0.2.0 is released, I just opened a PR against num-traits: rust-num/num-traits#144 |
|
Looks like your PR to num-traits with the new libm made it to crates.io in |
Version 0.2.10 of num-traits now includes the no-std support.
|
Alright, I bumped the version and it seems to work now. |
|
Thanks for your persistence! @bors-servo r+ |
|
📌 Commit 7ce307b has been approved by |
Implement actual support for no_std With num-traits having recently gained full support for no_std by using the libm crate, this crate can now fully support no_std as well without any sacrifices. Currently num-traits has not released a new version yet, so this uses a git dependency until then. Additionally the tests should fail at the moment when using the libm, as there actually was a bug in libm, but I have created a PR for it. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/euclid/372) <!-- Reviewable:end -->
|
☀️ Test successful - checks-travis |
4 participants
With num-traits having recently gained full support for no_std by using the libm crate, this crate can now fully support no_std as well without any sacrifices.
Currently num-traits has not released a new version yet, so this uses a git dependency until then.
Additionally the tests should fail at the moment when using the libm, as there actually was a bug in libm, but I have created a PR for it.
This change is