Replace the define_matrix! macro using a proc macro.#314
Merged
bors-servo merged 11 commits intomasterfrom Jan 12, 2019
Merged
Conversation
Remove unused dependencies and such.
We could relax these if necessary, but for this PR we should preserve behavior.
Member
Author
Member
Author
|
@bors-servo r=nox We could use a |
Contributor
|
📌 Commit 9e0f245 has been approved by |
Contributor
bors-servo
pushed a commit
that referenced
this pull request
Jan 12, 2019
Replace the `define_matrix!` macro using a proc macro. This will allow `cbindgen` to parse this without macro expansion, which will allow us to do it much faster, and at build-time. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/euclid/314) <!-- Reviewable:end -->
Contributor
|
☀️ Test successful - checks-travis |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will allow
cbindgento parse this without macro expansion, which will allow us to do it much faster, and at build-time.This change is