Automatic opening #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
automatically opens a diagram for .sw.json or .sw.yaml files related to serverlessworkflow#29 Signed-off-by: Jean-Baptiste Bianchi <[email protected]>
Signed-off-by: Jean-Baptiste Bianchi <[email protected]>
ricardozanini
approved these changes
Mar 26, 2024
|
@JBBianchi are we ready? |
|
Sure, let's say we'll collect live feedback :D |
|
Fixes #29 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Many thanks for submitting your Pull Request ❤️!
What this PR does / why we need it:
As asked in #29, automatically opens a diagram for JSON/YAML when the filename contains
.sw.Special notes for reviewers:
Additional information (if needed):
During local debugging, I'm facing a strange behavior. I need to first open a diagram manually for the automatic behavior to kick-in. If anybody else can test, that would be great <3