Remove Python 2.7 support #603
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miketheman
previously approved these changes
Apr 14, 2021
There was a problem hiding this comment.
Yay! Thanks for taking this up. I'm in favor of dumping 2.7 post-haste.
3.6 is EOL at the end of this year, so we also probably want to start thinking about 3.7 and higher.
https://endoflife.date/python
Co-authored-by: Mike Fiedler <[email protected]>
|
Hey @bsamuel-ui - I'm going to close this PR - I'm currently in process of updating the supported versions, so I'll handle droping Python 2.7 in future PRs. Thanks 🙇 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This drops python 2.7 support from the tests.
It further updates the README to explain the situation. While we're not explicitly breaking 2.7 support, we're no longer enforcing it, so this requires a major version increment per semver.
Scanning through the codebase, there's no conditional logic to support python 2.7 that I could find. And that makes sense: we delegate to tools that provide 2.7 support. So, most likely, if someone wanted to use the plugin with an older
pip, it would Just Work.I'm also proposing that we reject future fixes that require conditional logic; given that we have none now and those would be quite gory, I don't think this will matter much, but it does lay out the practical implications of dropping support.
Testing
Not much to do here beyond making sure the test suite runs correctly.