Improve runtime validation #629
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miguel-a-calles-mba
changed the base branch from
release/5.3.4
to
release/5.4.0
j0k3r
reviewed
Sep 3, 2020
|
@j0k3r, here it is. #628 (comment) |
j0k3r
force-pushed
the
bugfix/runtime-validation
branch
from
2dd37a0 to
744f74d
Compare
j0k3r
approved these changes
Sep 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What did you implement:
Closes #628 v5.3.3 has "match" error when trying to deploy
Validate the runtime exists.
How did you implement it:
How can we verify it:
Remove the
runtimeproperty from theprovidersection in theserverless.ymlfile.Todos:
Is this ready for review?: YES
Is it a breaking change?: NO