Vscode debug #365
Merged
Vscode debug #365
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HyperBrain
reviewed
Apr 6, 2018
| @@ -2,6 +2,7 @@ service: babel-webpack-4-example | |||
|
|
|||
| # Add the serverless-webpack plugin | |||
| plugins: | |||
| - serverless-offline | |||
There was a problem hiding this comment.
I think this order should be reversed, shouldn't it? The sls-webpack hooks should precede the offline hooks internally.
There was a problem hiding this comment.
It worked for me this way, but I realized that at README we state to use serverless-offline after serverless-webpack so I'm going to change it.
HyperBrain
approved these changes
Apr 6, 2018
This was referenced Sep 23, 2018
1 task
jamesmbourne
pushed a commit
to jamesmbourne/serverless-webpack
that referenced
this pull request
Oct 15, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What did you implement:
Closes #364
How did you implement it:
Adding a
.vscode/launch.jsonto provide debug feature usingvscode.How can we verify it:
babel-webpack-4example foldernpm installvscodeusing all the provided configurations.Todos:
Is this ready for review?: YES
Is it a breaking change?: NO