-
Notifications
You must be signed in to change notification settings - Fork 417
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow webpack stats option to overwrite default behaviour #261
Allow webpack stats option to overwrite default behaviour #261
Conversation
Thanks. The implementation looks good 🙌 |
ca8670e
to
fb6d36f
Compare
fb6d36f
to
a4ed8a1
Compare
@HyperBrain it's done. 😄 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now it's complete! Thank you.
This doesn't do anything on my project. Here's my config:
Package versions:
I still get the same display in the console even though I added |
@dashmug That's strange. |
@HyperBrain not sure. I'll have a look after work. |
I used |
I found the problem: If you have The fix should be easy. @HyperBrain is there a good way to unit test this thing? |
What did you implement:
Closes #260
How did you implement it:
When console log the compile stats, if webpack.config.js has stats configured, use it. Otherwise use default behaviour.
How can we verify it:
Using example/serverless-offline with default config:
After add

stats: 'minimal'
to webpack config:Todos:
Is this ready for review?: YES
Is it a breaking change?: NO