Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add and include peer dependencies #231

Merged
merged 3 commits into from
Sep 21, 2017
Merged

Add and include peer dependencies #231

merged 3 commits into from
Sep 21, 2017

Conversation

HyperBrain
Copy link
Member

@HyperBrain HyperBrain commented Sep 19, 2017

What did you implement:

Relates to #230
Closes #223

How did you implement it:

When adding external dependencies, their peer dependencies are now included too. This will add dependencies that are missed by Webpack if only the dependency requires its peer, but not the project's code.

Each dependency is checked for peers.

How can we verify it:

Use a project that depends on request-promise but does not use request internally. The project
must depend on request too, because it is a peer dependency of request-promise.

Todos:

  • Write tests
  • Write documentation
  • Fix linting errors
  • Make sure code coverage hasn't dropped
  • Provide verification config / commands / resources
  • Enable "Allow edits from maintainers" for this PR
  • Update the messages below

Is this ready for review?: YES
Is it a breaking change?: NO

@HyperBrain HyperBrain merged commit 68104f6 into master Sep 21, 2017
@HyperBrain HyperBrain deleted the include-dep-peerdeps branch September 21, 2017 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant