Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What did you implement:
Relates to #230
Closes #223
How did you implement it:
When adding external dependencies, their peer dependencies are now included too. This will add dependencies that are missed by Webpack if only the dependency requires its peer, but not the project's code.
Each dependency is checked for peers.
How can we verify it:
Use a project that depends on
request-promise
but does not userequest
internally. The projectmust depend on
request
too, because it is a peer dependency ofrequest-promise
.Todos:
Is this ready for review?: YES
Is it a breaking change?: NO