Fix: Disable cmdk internal filtering to prevent stale search results in MultiSelect #77
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes an issue where editing the search query in the MultiSelect component could cause valid options to disappear until the search input was completely cleared.
When both cmdk’s internal filtering and the component’s manual
.filter()logic ran simultaneously, the internal filter could cache a “no results” state and fail to update when the user backspaced or edited their input.Root Cause
<Command>component from cmdk performs built-in filtering by default.searchValue.Screen recordings
Bug encountered
multi-select-bug.mov
Post-Fix
multi-select-fix.mov