feat: implemented native cmdk.Command filtering #74
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Removed custom filtering code - Implemented support for `option.keywords` as per cmdk.Command - Implemented support for `filter` as per cmdk.Command - Removed announcement of filtered values - Updated documentation - Added keyword to sample framework for demonstration
|
@pete-otaqui is attempting to deploy a commit to the sersavan's projects Team on Vercel. A member of the Team first needs to authorize it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
option.keywordsas per cmdk.Commandfilteras per cmdk.Command--
the underlying
Commandcomponent fromcmdkalready has filtering built in. In fact, this isn't even turned off inMultiSelect, so filtering is currently happening twice.This PR removes the MultiSelect filtering in favor of implementing better support for Command's filtering capabilities, specifically to supply
keywordsto options, and ultimately to provide a completely customfilterfunction altogether.