-
Notifications
You must be signed in to change notification settings - Fork 979
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add travis-ci, run tests with phantomjs #303
base: master
Are you sure you want to change the base?
Conversation
singleRun: false prevents the tests from completing, as the first set of tests never exits, so the second set of tests never begins.
So, this gets the test process working non-interactively, but there are 3 errors existing in the current test cases. I haven't yet had time to see if the tests themselves are broken, or if there's something up with the library. First error:
Second error (looks to be same as first error, different test though)
Third error looks like a decode error
|
ok, so, for ean_extended/image-001.jpg and code_39/image-007.jpg the callback is being called without a codeResult. For ean_8/image-005.jpg, it's returning the wrong code. |
Sometimes, the 3rd error (ean_8/image-005.jpg) doesn't come up, but sometimes a different third one does:
So, it seems we have some non-deterministic results coming from ean_8 and upc_e .. and some total failures from ean_2_reader and code_39. |
Consistently, on the travis machine that was doing testing, the tests that I commented out here failed 74d8673 ... but they did not fail for me on my local machine. It seems to me that there's definitely some strange things afoot in some of the readers, possibly? |
I don't want to merge this until there's some input from others -- not just "looks good", but in regards to the actual functionality -- I couldn't get the tests to run in Chrome at all, I don't know if I was failing at some configuration step or missing some step, or what. I don't know if there's any disadvantages to running in PhantomJS versus Chrome, so long as Phantom has the support for what is needed (which it seems to, after plugging in the Promises polyfill for it) . . I would think that for now, it would be good to go with it. I'm not sure if there's an easy way to enable the "watch" mode for testing -- I disabled it here so that the Travis builds would complete, instead of hang watching for file updates .. i'd definitely like to have file watcher on for tests, though, that's super convenient to do quick changes in development. Basically, I'm sure that this is a change that is in the right direction, for the time being, but we may have to go in a different direction with some of these changes, or add more to these changes, such as not eliminating test watching. :-) |
needs some additional work and discussion before merging.