DRAFT: asusd: Add at v6.0.12 #446
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You need to fix the homepage in the stone.yaml |
Thanks yeah, is draft - I'm actively working on asusd itself to fix a few issues too. |
Add asusd laptop control daemon for ASUS laptops. Signed-off-by: Luke D. Jones <[email protected]>
ReillyBrogan
requested changes
Dec 24, 2024
There was a problem hiding this comment.
I was going to leave specific comments here, but honestly I'm very confused by this build.
- Why is it specifying
toolchain: gnu, does it not build with Clang? - Is mold a build requirement or is it just because it shaves a bit of time off the build? (hint: if I'm asking this question it's because there should be a comment in the recipe explaining the choice)
- Why is it pulling in
cmakewhen it appears to usemake?
|
Oh okay I just realized that you copied and pasted what was in the zed recipe. Feel free to ping me when you want this to actually be reviewed then. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add asusd laptop control daemon for ASUS laptops.