Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: When use redis store event, incorrect key was used to query the … #1628

Merged
merged 1 commit into from
Sep 25, 2024

Conversation

AYue-94
Copy link

@AYue-94 AYue-94 commented Sep 23, 2024

What type of PR is this?

Bug

What this PR does / why we need it?

When use redis store event, incorrect key was used to query the InstanceMeta.

Which issue(s) this PR fixes?

Fixes #1616

Does this PR introduce a user-facing change?

No

Checklist

  • Make sure there is a GitHub_issue related with this PR before you start working on it.
  • Make sure you have squashed your change to one single commit.
  • GitHub Actions works fine in this PR.

Copy link

codecov bot commented Sep 23, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
.../io/sermant/backend/dao/redis/RedisClientImpl.java 0.00% 1 Missing ⚠️
Flag Coverage Δ Complexity Δ
unittests 44.10% <0.00%> (ø) 182.00 <0.00> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ Complexity Δ
...va/io/sermant/backend/common/conf/CommonConst.java 0.00% <ø> (ø) 0.00 <0.00> (ø)
.../io/sermant/backend/dao/redis/RedisClientImpl.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)

@lilai23
Copy link
Collaborator

lilai23 commented Sep 23, 2024

Have you already in our wechat group? If not could you send your wechat account to my email [email protected] please. I hope to have a chat with you

@AYue-94
Copy link
Author

AYue-94 commented Sep 25, 2024

Have you already in our wechat group? If not could you send your wechat account to my email [email protected] please. I hope to have a chat with you

I'm not in, I send my wechat account to you

@Sherlockhan Sherlockhan merged commit fb8b875 into sermant-io:develop Sep 25, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

When use redis store event, backend send webhook error
4 participants