Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #957 [ReadFrom.Configuration(...) throws an exception on AWS..] #44

Merged
merged 3 commits into from
Apr 5, 2017
Merged

Fix #957 [ReadFrom.Configuration(...) throws an exception on AWS..] #44

merged 3 commits into from
Apr 5, 2017

Conversation

skomis-mm
Copy link
Contributor

@skomis-mm skomis-mm commented Apr 5, 2017 •
edited
Loading

Contains 2 commits:

  • vs2017 tooling update with some cleanup. Will reproduce issue on full .net in the test project.
  • fixes #957 (when Assembly.GetEntryAssembly() is null):
    • workaround for netcoreapp - use Using section.
    • workaround for full .net - not required (will use conventions to lookup for configuration assemblies) or use Using section.

nblumhardt
nblumhardt reviewed Apr 5, 2017
View reviewed changes
Build.ps1 Outdated
@@ -20,7 +20,7 @@ foreach ($src in ls src/*) {

echo "build: Packaging project in $src"

& dotnet pack -c Release -o ..\..\artifacts --version-suffix=$suffix
& dotnet pack -c Release -o ..\..\.\artifacts --version-suffix=$suffix --include-source
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the .\ redundant in this path?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

indeed :)

nblumhardt
nblumhardt reviewed Apr 5, 2017
View reviewed changes
Copy link
Member

@nblumhardt nblumhardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me; just had one trivial observation. I think we should :shipit: !

@nblumhardt nblumhardt merged commit 7ce6fa9 into serilog:dev Apr 5, 2017
@nblumhardt nblumhardt mentioned this pull request Apr 5, 2017
Merged
@skomis-mm skomis-mm deleted the issue957 branch April 5, 2017 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nblumhardt nblumhardt nblumhardt left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ReadFrom.Configuration(...) throws an exception on AWS Lambda when dynamically loading sinks
2 participants
@skomis-mm @nblumhardt