Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DllScanningAssemblyFinder fixes (#157, #150, #122, #156) #159

Merged
merged 2 commits into from
Jan 7, 2019
Merged

DllScanningAssemblyFinder fixes (#157, #150, #122, #156) #159

merged 2 commits into from
Jan 7, 2019

Conversation

skomis-mm
Copy link
Contributor

@skomis-mm skomis-mm commented Jan 4, 2019 •
edited
Loading

  • ArgumentNullException fix when AppDomain.CurrentDomain.BaseDirectory is null
  • additional paths probing: AppDomainSetup.PrivateBinPath, current assembly location path when BaseDirectory is null

Fixes #150, #157, #122, #156

DllScanningAssemblyFinder fixes:
297a132 
- ArgumentNullException fix when BaseDirectory is null
- additional paths probing:  AppDomainSetup.PrivateBinPath, current assembly location path when BaseDirectory is null
@skomis-mm skomis-mm changed the title DllScanningAssemblyFinder fixes (#157, #150) DllScanningAssemblyFinder fixes (#157, #150, #122) Jan 4, 2019
@skomis-mm skomis-mm changed the title DllScanningAssemblyFinder fixes (#157, #150, #122) DllScanningAssemblyFinder fixes (#157, #150, #122, #156) Jan 4, 2019
tsimbalar
tsimbalar approved these changes Jan 4, 2019
View reviewed changes
Copy link
Member

@tsimbalar tsimbalar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good !

In the end, I'm not entirely sure to which extent the behavior will be different in .NET Core versus Full Framework ... Maybe we should mention it somewhere in the README to clarify it ? (and so that it does not look like a bug)

@skomis-mm
Copy link
Contributor Author

skomis-mm commented Jan 5, 2019 •
edited
Loading

@tsimbalar there is not much difference: DependencyContext can be used for both, CurrentDomain.BaseDirectory can be used for both too.
The difference for classic web applications is additional probing path (bin directory via setting AppDomainSetup.PrivateBinPath which is configured for the Full Framework).

DllScanningAssemblyFinderTests
cf2bb1b 
- extract strings to constants
@tsimbalar
Copy link
Member

LGTM ! :shipit:

@skomis-mm skomis-mm merged commit 3cf169d into serilog:dev Jan 7, 2019
@skomis-mm skomis-mm mentioned this pull request Jan 7, 2019
Closed
7 tasks
@tsimbalar tsimbalar mentioned this pull request Mar 25, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tsimbalar tsimbalar tsimbalar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ConfigurationReader in Android throw exceptions.
2 participants
@skomis-mm @tsimbalar