Exceptions when misconfigured #155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skomis-mm
reviewed
Jan 5, 2019
There was a problem hiding this comment.
Thanks, @mashbrno 👍 .
It would be great if this would be a part of a bigger change (feature with strict/non strict validation behavior). For this kind of local change it would be better to just emit errors to the SelfLog instead of throwing them to align with other places and the current behavior.
…figuration into dev # Conflicts: # src/Serilog.Settings.Configuration/Settings/Configuration/ConfigurationReader.cs
|
I've merge latest changes from dev and replaced Expcetions with SelfLog. |
Merged
|
Thanks! |
|
(Unfortunately my trigger finger was too quick and I merged this with the original PR title "Exceptions when misconfigured" - I should have noted "Improved SelfLog messages when misconfigured" - just force-pushed the better message). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of my JSON configuration was skipped. After few hours debugging I found that it silently drops parts unable to load. Please revise my attempt to provide some meaningful Exception.