Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build a package version for net461 #124

Merged
merged 1 commit into from
Jul 28, 2018

Conversation

alastairs
Copy link
Contributor

This will be resolved by NuGet for .NET Framework 4.6.1 upward, and is equivalent to the netstandard2.0 package version.

Fixes #123.

This will be resolved by NuGet for .NET Framework 4.6.1 upward, and is
equivalent to the netstandard2.0 package version.
@MV10
Copy link
Contributor

MV10 commented Jul 26, 2018

When I made the multi-target changes, I believe someone told me Serilog still has .NET 4.5.x users...

@alastairs
Copy link
Contributor Author

alastairs commented Jul 26, 2018

Thanks @MV10. I don't believe my proposed changes remove support for those users?

@MV10
Copy link
Contributor

MV10 commented Jul 26, 2018

Oops, you're right, sorry about that.

Did you see the NuGet issue I linked to in #123? I don't use .NET Framework at all now, so I can't easily check this, but I'm wondering if this change prevents .NET Framework apps from using the old config if that is a requirement.

@alastairs
Copy link
Contributor Author

Hi, yes, I did. I wonder if there's a difference in the way the projects are built. We are using the .NET SDK across all of our projects (mostly targeting .netcoreapp2.0, but some target net471 as per #123), and we use the new-style .csproj files with PackageReferences everywhere. We do definitely the see the opposite of what is reported in that linked issue. I'm not sure, but am wondering if the project in the linked issue is an old-style .NET Framework project.

@MV10
Copy link
Contributor

MV10 commented Jul 28, 2018

I hadn't realized how far the latest VS goes to bury .NET Framework, it took me quite awhile to even figure out how to target it, but I think it tests out OK, at least building a NuGet package locally (I can't be 100% sure it'll match the published Serilog packaging, I can't see how that is set up).

Incidentally Nick commented on one of my PRs that we may need to consider dropping support for older versions, but it doesn't look like that day is upon us yet.

Looks good to me, PR merge in 3, 2, 1...

@MV10 MV10 merged commit a6177b7 into serilog:dev Jul 28, 2018
@alastairs
Copy link
Contributor Author

Brill, thanks @MV10!

@alastairs alastairs deleted the bug/123/fix-net451-dependencies branch July 28, 2018 12:08
@merbla merbla mentioned this pull request Oct 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

In projects targeting .NET 4.7, the net451 assembly is resolved
2 participants