Merge pull request #368 from 0xced/Better-SelfLogs

Improve SelfLog when a configuration method is not found
serilog · Mar 21, 2023 · eae1ded · eae1ded
2 parents ae0e57e + 4ab71a9
commit eae1ded
Showing 1 changed file with 12 additions and 2 deletions.
diff --git a/src/Serilog.Settings.Configuration/Settings/Configuration/ConfigurationReader.cs b/src/Serilog.Settings.Configuration/Settings/Configuration/ConfigurationReader.cs
@@ -470,17 +470,27 @@ static bool HasImplicitValueWhenNotSpecified(ParameterInfo paramInfo)
                 .ToList();
 
             if (!methodsByName.Any())
-                SelfLog.WriteLine($"Unable to find a method called {name}. Candidate methods are:{Environment.NewLine}{string.Join(Environment.NewLine, candidateMethods)}");
+            {
+                if (candidateMethods.Any())
+                {
+                    SelfLog.WriteLine($"Unable to find a method called {name}. Candidate methods are:{Environment.NewLine}{string.Join(Environment.NewLine, candidateMethods)}");
+                }
+                else
+                {
+                    SelfLog.WriteLine($"Unable to find a method called {name}. No candidates found.");
+                }
+            }
             else
+            {
                 SelfLog.WriteLine($"Unable to find a method called {name} "
                 + (suppliedArgumentNames.Any()
                     ? "for supplied arguments: " + string.Join(", ", suppliedArgumentNames)
                     : "with no supplied arguments")
                 + ". Candidate methods are:"
                 + Environment.NewLine
                 + string.Join(Environment.NewLine, methodsByName));
+            }
         }
-
         return selectedMethod;
     }