v7 - pin to Microsoft.Extensions.Logging v7
#222
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… Serilog v2.12 and apply annotations for nullable reference types
nblumhardt
changed the title
Microsoft.Extensions.Logging v7
This was referenced May 3, 2023
|
@nblumhardt always happy to have my PRs closed. i can submit a new one, just let me know |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From v7.0.0 forwards, Serilog.Extensions.Logging, Serilog.Extensions.Hosting, and Serilog.AspNetCore will all be pinned to corresponding versions of the Microsoft.Extensions.* libraries that they implement. This is expected to address long-running compatibility headaches, and reduce security scanner false-positives.
Unless we have a good reason not to, this will also mean matching the TFMs supported by those libraries.
In the current case, this means that we'll add some explicit targets for TFMs that the package already covered via
netstandard2.0.The other changes in this PR just get the codebase building, fixing nullable reference type annotations and dealing with the usual dependency gunk. @SimonCropp some of this unfortunately overlaps with #219 - I'll sort that out post-merge :-) sorry!
Edit: since Serilog.Settings.Configuration also tracks a Microsoft.Extensions package I'm including it in this list, too.