Fix freezing of CachingReloadableLoggers #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nblumhardt
commented
Mar 2, 2021
| if (cached != null && root == _logger) | ||
| { | ||
| newRoot = default; | ||
| newCached = default; | ||
| frozen = _frozen; | ||
| return (cached, frozen); // If we're frozen, then the caller hasn't observed this yet and should update. |
There was a problem hiding this comment.
The issue is here - even if frozen is true, the caching wrapper may never have seen the final logger (or any logger) - we need to propagate it as we do via line 375 in the new version.
|
I'm going to merge this since the published version is quite badly broken :( .. more eyes still appreciated on this if anyone has the time to take a look. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #39
The issue turned out to be logical rather than concurrency-related, but in the process of finding it I spotted some suspicious synchronization and got a bit more defensive about it, too.