Bring sample app more in line with Microsoft docs #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Update the sample project to use the `Microsoft.NET.Sdk.Worker` SDK. This is the default SDK when creating a new project from the template 'Worker Service'. - Target `netcore3.1`. - Simplify the sample service by deriving from `BackgroundService` instead of implementing `IHostedService` directly. This leads to a simpler example (better focus on the mechanics of setting up and configuring Serilog). As there are some caveats with implementing `IHostedService` directly, devs new to worker services are better of starting from `BackgroundService`. - Start tracking `launchSettings.json`.
6 tasks
|
Awesome 👍 |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to bring the included
SimpleServiceSamplebetter in line with the samples given in the Microsoft docs. I think we should strive to keep as close as possible to the archetypical samples given by Microsoft. That makes the typical setup of a hosted service/background service better recognizable, and shows better what is typical to setting up Serilog.This PR:
Microsoft.NET.Sdk.WorkerSDK. This is the default SDK when creating a new project from the template 'Worker Service'.netcore3.1.BackgroundServiceinstead of implementingIHostedServicedirectly. This leads to a simpler example (better focus on the mechanics of setting up and configuring Serilog). As there are some caveats with implementingIHostedServicedirectly, devs new to worker services are better of starting fromBackgroundService.launchSettings.json.